TeamManager

Git Source

Overview

The TeamManager contract is a specialized token distribution system for the Lendefi DAO, designed to handle team member compensation through configurable vesting schedules. It allocates 18% of the total token supply to team members with controlled vesting parameters, providing both flexibility and security in managing team token allocations.

Architecture

Contract Structure

• Inheritance Model: Implements a comprehensive inheritance structure combining upgradeability, access control, reentrancy protection, and pausability

• Allocation Management: Tracks and enforces a fixed percentage (18%) allocation of total token supply

• Individual Vesting: Creates separate vesting contract instances for each team member

• Configurable Parameters: Allows customization of vesting schedules within predefined constraints

Token Distribution Model

• Fixed Allocation: 18% of total token supply reserved for team members

• Vesting Parameters:

  • Cliff periods: 90-365 days (3 months to 1 year)

  • Vesting durations: 365-1460 days (1-4 years)

• Custom Vesting Contracts: Deploys dedicated TeamVesting contracts for each member

Technical Assessment

Strengths

1. Security Features:

   • Role-based access control with distinct roles (PAUSER_ROLE, MANAGER_ROLE, UPGRADER_ROLE)

   • Reentrancy protection on fund-moving functions

   • Input validation with clear error messages

   • Pausability for emergency situations

   • UUPS upgrade pattern with version tracking

2. Parameter Validation:

   • Zero-address validation for critical parameters

   • Bounds checking for cliff and duration values

   • Allocation limit enforcement

   • Duplicate beneficiary prevention

3. Implementation Quality:

   • Clean function organization with logical separation

   • Event emissions for critical actions

   • Explicit error messages with custom errors

   • Safe token transfers using SafeERC20

4. Governance Integration:

   • Timelock control for key management functions

   • Guardian role for emergency actions

   • Version tracking for upgrade transparency

Potential Concerns

1. Limited Management Functions:

   • No mechanism to remove or adjust team member allocations

   • No recovery function for incorrect allocations

   • No batch operations for efficient team management

2. Centralization Risks:

   • Heavy reliance on timelock and guardian roles

   • No time-delayed operations for sensitive functions

3. Vesting Limitations:

   • Once created, vesting contracts cannot be modified

   • No partial vesting revocation capability for exiting team members

   • No mechanism to handle team restructuring events

4. Technical Considerations:

   • TeamVesting contract dependency is critical but separate

   • No explicit handling for token rebasing or fee-on-transfer tokens

   • Custom error messages not fully standardized

Code Quality & Documentation

• Documentation: Excellent NatSpec documentation with detailed parameter descriptions

• Security Annotations: Clear security-related annotations in comments

• Event Emissions: Appropriate event for critical state changes

• Error Handling: Consistent use of custom errors with descriptive messages

• Code Organization: Well-structured with logical sections and clear naming

Inherits: ITEAMMANAGER, Initializable, PausableUpgradeable, AccessControlUpgradeable, ReentrancyGuardUpgradeable, UUPSUpgradeable

Creates and deploys team vesting contracts

Implements a secure and upgradeable team manager for the DAO

Notes:

• security-contact: [e-mail]

• copyright: Copyright (c) 2025 Nebula Holding Inc. All rights reserved.

• oz-upgrades:

State Variables

TEAM_ALLOCATION_PERCENT

Team allocation percentage of total supply (18%)

uint256 private constant TEAM_ALLOCATION_PERCENT = 18;

MIN_CLIFF

Minimum cliff period (6 months)

uint64 public constant MIN_CLIFF = 90 days;

MAX_CLIFF

Maximum cliff period (2 years)

uint64 public constant MAX_CLIFF = 365 days;

MIN_DURATION

Minimum vesting duration (1 year)

uint64 public constant MIN_DURATION = 365 days;

MAX_DURATION

Maximum vesting duration (4 years)

uint64 public constant MAX_DURATION = 1460 days;

PAUSER_ROLE

AccessControl Pauser Role

bytes32 internal constant PAUSER_ROLE = keccak256("PAUSER_ROLE");

MANAGER_ROLE

AccessControl Manager Role

bytes32 internal constant MANAGER_ROLE = keccak256("MANAGER_ROLE");

UPGRADER_ROLE

AccessControl Upgrader Role

bytes32 internal constant UPGRADER_ROLE = keccak256("UPGRADER_ROLE");

ecosystemToken

governance token instance

ILENDEFI internal ecosystemToken;

supply

amount of ecosystem tokens in the contract

uint256 public supply;

totalAllocation

amount of tokens allocated so far

uint256 public totalAllocation;

timelock

timelock address

address public timelock;

version

number of UUPS upgrades

uint32 public version;

allocations

token allocations to team members

mapping(address src => uint256 amount) public allocations;

vestingContracts

vesting contract addresses for team members

mapping(address src => address vesting) public vestingContracts;

__gap

gap for future storage variables

uint256[50] private __gap;

Functions

receive

Prevents receiving Ether

receive() external payable;

constructor

Note: oz-upgrades-unsafe-allow: constructor

constructor();

initialize

Initializes the team manager contract

*Sets up the initial state of the contract with core functionality:

1. Initializes upgradeable base contracts

2. Sets up access control roles

3. Configures token and supply parameters*

Notes:

• requires-role: None - can only be called once during initialization

• security: Implements initializer modifier to prevent re-initialization

• security: Validates all input addresses are non-zero

• events-emits: Initialized(msg.sender)

• throws: CustomError("ZERO_ADDRESS_DETECTED") if any input address is zero

function initialize(address token, address timelock_, address guardian) external initializer;

Parameters

Name	Type	Description
token	address	The address of the ecosystem token contract
timelock_	address	The address of the timelock controller
guardian	address	The address of the admin who will receive DEFAULT_ADMIN_ROLE

pause

Pauses all contract operations

Prevents execution of state-modifying functions

Notes:

• requires-role: PAUSER_ROLE

• security: Inherits OpenZeppelin's PausableUpgradeable

• events-emits: {Paused} event from PausableUpgradeable

• throws: Unauthorized if caller lacks PAUSER_ROLE

function pause() external onlyRole(PAUSER_ROLE);

unpause

Resumes all contract operations

Re-enables execution of state-modifying functions

Notes:

• requires-role: PAUSER_ROLE

• security: Inherits OpenZeppelin's PausableUpgradeable

• events-emits: {Unpaused} event from PausableUpgradeable

• throws: Unauthorized if caller lacks PAUSER_ROLE

function unpause() external onlyRole(PAUSER_ROLE);

addTeamMember

Create and fund a vesting contract for a new team member

Notes:

• requires: beneficiary must not be zero address

• requires: cliff must be between MIN_CLIFF and MAX_CLIFF

• requires: duration must be between MIN_DURATION and MAX_DURATION

• requires: amount must not exceed remaining supply

• throws: CustomError("SUPPLY_LIMIT") if allocation exceeds supply

• throws: CustomError("INVALID_BENEFICIARY") if beneficiary is zero address

• throws: CustomError("INVALID_CLIFF") if cliff period is invalid

• throws: CustomError("INVALID_DURATION") if duration is invalid

• throws: CustomError("ALREADY_ADDED") if beneficiary already has allocation

function addTeamMember(address beneficiary, uint256 amount, uint256 cliff, uint256 duration)
    external
    nonReentrant
    whenNotPaused
    onlyRole(MANAGER_ROLE);

Parameters

Name	Type	Description
beneficiary	address	The address of the team member
amount	uint256	The amount of tokens to vest
cliff	uint256	The cliff period in seconds
duration	uint256	The vesting duration in seconds after cliff

_authorizeUpgrade

Authorizes and processes contract upgrades

Internal override for UUPS upgrade authorization

*Performs:

1. Validates caller has UPGRADER_ROLE

2. Increments contract version

3. Emits upgrade event with details*

Notes:

• throws: Unauthorized if caller lacks UPGRADER_ROLE

• emits: Upgrade event with upgrader address and new implementation

• security: Role-based access control via UPGRADER_ROLE

• security: Version tracking for upgrade management

• security: Inherits OpenZeppelin's UUPSUpgradeable pattern

function _authorizeUpgrade(address newImplementation) internal override onlyRole(UPGRADER_ROLE);

Parameters

Name	Type	Description
newImplementation	address	Address of the new implementation contract